Ticket #91 (new defect)

Opened 1 year ago

Last modified 7 months ago

Mac OSX buildbot slave confused by "cvs" on path

Reported by: joduinn Assigned to: joduinn
Priority: major Milestone: 0.8.0
Component: other Version: 0.7.5
Keywords: Cc: bhearsum@mozilla.com

Description

When a Mac OSX buildbot slave runs cvs, it behaves differently if a directory named "cvs" is found on the path.

For example, $ export | grep PATH declare -x PATH="/foo/cvs:/opt/local/bin:/tools/buildbot/bin:/tools/twisted/bin:/tools/twisted-core/bin:/tools/python/bin:/opt/local/bin:/opt/local/sbin:/bin:/sbin:/usr/bin:/usr/sbin"

...will cause buildbot to attempt to run a program called "/foo/cvs", which doesnt work. Instead, buildbot should run a program called "/foo/bar/cvs/cvs".

To work around this, rename "/foo/cvs" to be "/foo/bar", adjust the PATH to match, and restart buildbot slave. Now, buildbot will run a program called "/foo/bar/cvs", which works.

Change History

09/29/07 01:42:44 changed by warner

  • milestone changed from undecided to 0.7.7.

11/01/07 01:36:20 changed by warner

  • owner set to warner.
  • status changed from new to assigned.

that's.. weird. There's a function named 'which' that is used to locate a given command on $PATH, and I know it has some weird code to deal with windows command-extension issues.. I wonder if that's interacting with something here?

Now that I've got an OSX box of my own, I'll take a look at this.

03/17/08 17:13:17 changed by warner

  • owner changed from warner to joduinn.
  • status changed from assigned to new.

I can't reproduce this simply. Could you confirm that it's still happening? Also, if you could provide me with the top of the failing step's stdout (the one where it shows the environment and the command being run), that would help.

Also, what version of twisted is this using? (just include the output of 'buildbot --version' on that buildslave)

03/19/08 10:04:08 changed by bhearsum

  • cc set to bhearsum@mozilla.com.

03/22/08 17:56:32 changed by warner

  • milestone changed from 0.7.7 to 0.7.8.

I tried to reproduce this again (OS-X Tiger, buildbot 0.7.6+, twisted 2.5.0), and wasn't able to. I moved the system /usr/bin/cvs into a local directory named 'cvs', moved the original to 'cvs.OFF' so it wouldn't be found, added the local 'cvs' directory to PATH, and restarted the buildslave. That slave was able to find the new local/cvs/cvs binary and use it for an update operation.

Failing a way to reproduce this locally, I'm going to push this out of 0.7.7 and into the next release. If you can reproduce the problem on your end, please let me know.. we can compare notes and figure out what's going on.

05/02/08 16:24:36 changed by warner

  • milestone changed from 0.7.8 to 0.7.9.

joduinn: ping? we need to be able to reproduce this one, or we'll need to close as INVALID. Pushing out to 0.7.9 in the meantime.