New 'console view' broken

[Nicolas]

I upgraded to latest git (6a73602). The jinja-based web interface has a new "Console" page. However all it does on my system is throw an exception:

        Traceback (most recent call last):
          File "/usr/lib/python2.5/site-packages/twisted/protocols/basic.py", line 231, in dataReceived
            why = self.lineReceived(line)
          File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 1325, in lineReceived
            self.allContentReceived()
          File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 1391, in allContentReceived
            req.requestReceived(command, path, version)
          File "/usr/lib/python2.5/site-packages/twisted/web/http.py", line 714, in requestReceived
            self.process()
        --- <exception caught here> ---
          File "/usr/lib/python2.5/site-packages/twisted/web/server.py", line 150, in process
            self.render(resrc)
          File "/usr/lib/python2.5/site-packages/twisted/web/server.py", line 157, in render
            body = resrc.render(self)
          File "/usr/local/lib/python2.5/site-packages/buildbot/status/web/base.py", line 195, in render
            data = self.content(request, ctx)
          File "/usr/local/lib/python2.5/site-packages/buildbot/status/web/console.py", line 675, in content
            debugInfo)
          File "/usr/local/lib/python2.5/site-packages/buildbot/status/web/console.py", line 385, in getAllBuildsForRevision
            debugInfo)
          File "/usr/local/lib/python2.5/site-packages/buildbot/status/web/console.py", line 305, in getBuildsForRevision
            builder.getBuild(-1), revision)
          File "/usr/local/lib/python2.5/site-packages/buildbot/status/web/console.py", line 332, in getChangeForBuild
            changes.sort(key=self.comparator.getSortingKey())
        exceptions.AttributeError: 'tuple' object has no attribute 'sort'

Full stacktrace attached.

[Nicolas]

Stacktrace returned by /console

[marcusl]

Are you Nicolas Sylvain or Nicolas Alvarez? (could you change your user name=)

First, I was hoping that nsylvain could take a look at the port I did. Currently, console doesn't work for me on the release (0.7.12rc) branch either, so it was hard for me to test my jinja-fication properly.

Second, error seems to be related to abyx's fixes (he added the self.comparator object) so once that gets cleared up on the release branch, fixing the jinja-part will be much easier.

[marcusl]

Btw, does it work on the release (non-jinja) branch? (rev 7fdadb021398d7a244295707cebc643b761bdb88)

[Nicolas]

I'm Alvarez. Doesn't look like I can change my username though.

[marcusl]

Ok. I suppose you have to create a new account for that to work. Oh well. Now I know at least. ;)

Let us know if you get different results on the release branch, ok?

[marcusl]

Closing this now, as the console doesn't seem to crash for most people and those changes have been merged to master.

Reopen if the problem re-appears, ok?