Ticket #61 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

bonsaipoller bug fixes

Reported by: Pike Assigned to: warner
Priority: major Milestone: 0.7.6
Component: changesources Version: 0.7.5
Keywords: Cc: warner, Pike, joduinn

Description

bonsaipoller has a few bugs, which we fixed on the mozilla side, see bug 389645.

There's going to be a follow-up patch to use twistd.web instead of liburl to query bonsai without blocking and with a timeout.

Attachments

bonsaipoller.patch (1.3 kB) - added by Pike on 07/26/07 06:16:38.
support empty check-in comments, fix files array for multiple check-ins
bp-async.patch (1.7 kB) - added by Pike on 07/27/07 02:38:37.
use twisted.web.client.getPage instead of urllib.urlopen
test_bonsaipoller.patch (3.5 kB) - added by Pike on 08/03/07 07:48:57.
use content instead of StringIO for tests, now that BonsaiParser? takes content

Change History

07/26/07 06:16:38 changed by Pike

  • attachment bonsaipoller.patch added.

support empty check-in comments, fix files array for multiple check-ins

07/27/07 02:37:29 changed by Pike

  • cc set to warner.
  • owner changed from warner to Pike.

I just landed bug 389706, which replaces the call to urllib.urlopen with twisted.web.client.getPage. That's making bonsai poller query bonsai asynchronously, and adds support for timeouts, too. Thus, a dying bonsai doesn't block the complete master anymore. It's reviewed by bhearsum.

07/27/07 02:38:37 changed by Pike

  • attachment bp-async.patch added.

use twisted.web.client.getPage instead of urllib.urlopen

07/29/07 14:23:29 changed by warner

I tried applying these to current HEAD, but test_bonsaipoller then failed. Am I doing something wrong?

07/29/07 14:32:05 changed by warner

Here are the test failures I observed: 

===============================================================================
[ERROR]: buildbot.test.test_bonsaipoller.TestBonsaiPoller.testFullyFormedResult

Traceback (most recent call last):
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/test/test_bonsaipoller.py", line 119, in testFullyFormedResult
    br = BonsaiParser(StringIO(goodUnparsedResult))
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/changes/bonsaipoller.py", line 78, in __init__
    raise InvalidResultError("Malformed XML in result")
buildbot.changes.bonsaipoller.InvalidResultError: 'Malformed XML in result'
===============================================================================
[ERROR]: buildbot.test.test_bonsaipoller.TestBonsaiPoller.testMissingCiResult

Traceback (most recent call last):
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/test/test_bonsaipoller.py", line 171, in testMissingCiResult
    BonsaiParser(StringIO(missingCiResult))
  File "/home/warner/stuff/Projects/BuildBot/trees/bonsaipoller/buildbot/changes/bonsaipoller.py", line 78, in __init__
    raise InvalidResultError("Malformed XML in result")
buildbot.changes.bonsaipoller.InvalidResultError: 'Malformed XML in result'
-------------------------------------------------------------------------------

08/03/07 07:48:57 changed by Pike

  • attachment test_bonsaipoller.patch added.

use content instead of StringIO for tests, now that BonsaiParser? takes content

08/03/07 07:50:11 changed by Pike

  • cc changed from warner to warner, Pike.

oops, you caught me not running tests, obviously. Sorry.

The fix is simple, as the bonsai content handlers now take content instead of file-like objects, we mustn't use StringIO.

08/15/07 13:44:04 changed by Pike

Just landed the fix for the tests on our repository, with r=bhearsum.

09/29/07 00:43:50 changed by warner

  • owner changed from Pike to warner.
  • status changed from new to assigned.
  • milestone set to 0.7.6.

09/29/07 00:47:28 changed by joduinn

  • cc changed from warner, Pike to warner, Pike, joduinn.

09/29/07 13:48:38 changed by warner

  • status changed from assigned to closed.
  • resolution set to fixed.

applied, in [457].