Ticket #56 (closed enhancement: fixed)

Opened 1 year ago

Last modified 9 months ago

custom properties for triggerable schedulers

Reported by: dustin Assigned to: warner
Priority: major Milestone: 0.7.8
Component: buildprocess Version:
Keywords: Cc: gerg.ward+buildbot@gmail.com, bhearsum@mozilla.com

Description

Discussion was here:

http://article.gmane.org/gmane.comp.python.buildbot.devel/2064

This basically provides an alternative to the dependent scheduler, allowing more sophisticated scheduling of inter-dependent builders.

Attachments

trigger.patch (14.1 kB) - added by dustin on 07/24/07 11:59:39.
buildsteps can trigger schedulers
bb-item56-0.7.6fix.patch (0.5 kB) - added by gward on 10/19/07 15:17:50.
0.7.6 compatibility fix (allows passing Trigger instances to factory.addStep())
triggerable.patch (13.9 kB) - added by dustin on 01/13/08 18:49:16.
customprops_trigger.diff (2.9 kB) - added by redsymbol on 02/06/08 17:13:58.
Custom props to triggers for 0.7.6. Assumes customprops076.tgz and customprops_web.diff from ticket #87 have been applied, as well as trigger.patch and bb-item56-0.7.6fix.patch from this ticket

Change History

07/24/07 11:59:39 changed by dustin

  • attachment trigger.patch added.

buildsteps can trigger schedulers

07/24/07 12:01:27 changed by dustin

Note that the tests in this patch require the patch from #57.

07/30/07 20:28:06 changed by dustin

  • version deleted.

Also note that, if #71 is applied, this patch should be modified to use it.

10/01/07 13:05:54 changed by warner

  • milestone set to 0.8.0.

10/19/07 15:17:14 changed by gward

This patch is still useful and relevant with Buildbot 0.7.6. It applies cleanly, and *almost* works. In particular, it works fine as long as you keep using the 0.7.5 style of

factory.addStep(Trigger, ...)

but if you switch to the 0.7.6 style

factory.addStep(Trigger(...))

it fails. This is because BuildStep.init() is not saving enough kwargs in self.factory, which in turn is because Trigger.init() does not pass all of its kwargs up. I'll attach one possible fix (as a patch relative to Dustin's original patch).

10/19/07 15:17:50 changed by gward

  • attachment bb-item56-0.7.6fix.patch added.

0.7.6 compatibility fix (allows passing Trigger instances to factory.addStep())

10/19/07 15:18:42 changed by gward

  • cc set to gerg.ward+buildbot@gmail.com.

01/13/08 18:49:16 changed by dustin

  • attachment triggerable.patch added.

01/13/08 18:50:53 changed by dustin

  • milestone changed from 0.8.0 to 0.7.7.

Updated patch against latest head. This, too,has been requested a few times on the mailing list, so I'd like to see it in the next release. Available as 'triggerable.patch' in http://darcs.r.igoro.us/buildbot/trunk.

01/31/08 18:46:54 changed by spiff

Is this patch missing a patch to sourcestamp.py? I don't see where getAbsoluteSourceStamp is defined.

02/01/08 07:47:26 changed by dustin

spiff -- that's in #71.

02/06/08 17:13:58 changed by redsymbol

  • attachment customprops_trigger.diff added.

Custom props to triggers for 0.7.6. Assumes customprops076.tgz and customprops_web.diff from ticket #87 have been applied, as well as trigger.patch and bb-item56-0.7.6fix.patch from this ticket

02/16/08 21:08:45 changed by dustin

everything but the customprops patch is available as "#56:trigger.patch" from http://darcs.r.igoro.us/buildbot/dustin/.

03/19/08 10:04:53 changed by bhearsum

  • cc changed from gerg.ward+buildbot@gmail.com to gerg.ward+buildbot@gmail.com, bhearsum@mozilla.com.

03/20/08 18:41:11 changed by warner

I've applied all the 56-related patches from dustin's repository, and done some further cleanups on top of them (renamed schedulers= to schedulerNames=, and make updateSourceStamp be True by default). I'll look at the "custom props" patches now.

03/20/08 18:44:18 changed by warner

  • summary changed from triggerable schedulers to custom properties for triggerable schedulers.
  • milestone changed from 0.7.7 to 0.7.8.

Ok, I don't understand the "custom properties" stuff, like what is the difference between a custom property and a regular one. I'm going to rename the remainder of this ticket to "custom properties for triggerable schedulers" and push it out to the next release. At least the base triggerable stuff is now in 0.7.7 .

04/19/08 12:45:10 changed by dustin

  • status changed from new to closed.
  • resolution set to fixed.

This got solved in #87/#124.