Ticket #52 (closed enhancement: fixed)

Opened 2 years ago

Last modified 10 months ago

allow WithProperties in ShellCommand environment variable specifications

Reported by: warner Assigned to: warner
Priority: minor Milestone: 0.7.7
Component: buildprocess Version: 0.7.5
Keywords: Cc:

Description

Albert Hofkamp reported (in #43) that WithProperties? should be accepted in the workdir= argument, and now it is. He also reports that it ought to be accepted in the buildslave environment-variable specification, and provides the attached patch to implement this.

Attachments

wp-env.diff (2.9 kB) - added by warner on 07/07/07 18:37:06.
patch to add WithProperties? to environment variables

Change History

07/07/07 18:37:06 changed by warner

  • attachment wp-env.diff added.

patch to add WithProperties? to environment variables

07/09/07 23:51:17 changed by albertHofkamp

One or two days after posting the wp-env patch, Axel Hecht found an error in the patch (tnx Axel!), and posted it also at the mailing list: 

> Axel Hecht wrote:
> > Did you mean to use new_key in the second line?
> >
> > +                new_key = self._interpolateProperties(key)
> > +                new_dict[key] = self._interpolateProperties(val)
>
> You are correct, it should have been 'new_key'.

The line number of the change is 173 in the new version of the file.

10/01/07 13:07:04 changed by warner

  • milestone set to 0.7.7.

03/18/08 13:08:48 changed by warner

  • status changed from new to closed.
  • resolution set to fixed.

Applied, in [538]. Thanks!