Patch to let svn use username and password for checkout or update

Patch against 0.7.5 to let svn use --username and --password

looks pretty good. If you add some docs to docs/buildbot.texinfo describing the new parameters then I'll go ahead and apply it.

Also, instead of pulling the username/password out of kwargs, just pull them out as regular arguments:

buildbot/steps/source.py:
class SVN(...)
    def __init__(self, ...
                 username=None, password=None, **kwargs)
...

thanks,

-Brian

note to self: when closing this one, also close SF#1685034

I seem to remember that when this has come up before, folks have pointed out that the password you use for this will be displayed in the logs of the checkout step. If your buildmaster is private and the logs aren't visible to the world, this is probably ok (it probably means that your SVN server is world-visible, and you're using the password to restrict access to it, but the buildmaster is visible to everybody who can read from your SVN server anyway).

It would probably be worthwhile to make a note of this fact in the docs, though. These docs want to go into the 'SVN' node (grep for '@node SVN'), around line 3716 of current trunk.

Replying to warner:

I seem to remember that when this has come up before, folks have pointed out that the password you use for this will be displayed in the logs of the checkout step. If your buildmaster is private and the logs aren't visible to the world, this is probably ok (it probably means that your SVN server is world-visible, and you're using the password to restrict access to it, but the buildmaster is visible to everybody who can read from your SVN server anyway).

You're right, and this is a clear problem. I may have a potential solution to suggest (once I get back home -- I'm on vacation with limited connectivity right now).

It would probably be worthwhile to make a note of this fact in the docs, though. These docs want to go into the 'SVN' node (grep for '@node SVN'), around line 3716 of current trunk.

0.7.6 is right around the corner, so I'm pushing this one out to the following release until we get the docs and resolve the password-in-the-clear issue

no progress on this yet, bumping to 0.7.8

There are other options it would be nice to pass to svn commands. For example, I want to pass --ignore-externals. Maybe it would make sense to just generalize the SVN step to allow arbitrary argments?

Generalizing to allow custom commands is good, but some kind of obfuscation for the password part would be good. (Perhaps allow a buildstep to override the display string, so the SVN-step can replace the password with <<secret>> or something)