Ticket #39 (new defect)

Opened 2 years ago

Last modified 1 year ago

reconfig reports incorrect changes between locks

Reported by: darraghbailey Assigned to: warner
Priority: trivial Milestone: 0.8.0
Component: buildprocess Version:
Keywords: Cc:

Description

When performing a reconfig after updating the locks being used to include a new lock the following was the output into the log file and onto the screen. 

locks changed from [(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3_serverbuilds'),
 (<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')] to 
[(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')]

It should read 

locks changed from [(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')] to 
[(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3_serverbuilds'), 
(<class buildbot.locks.MasterLock at 0x2000000000fed350>, 'machine3')]

Since I was adding the new lock machine3_serverbuilds, not removing it.

Attachments

buildbot-reconfig-locks-reorder.patch (0.7 kB) - added by darraghbailey on 05/15/07 07:53:20.
patch to print the correct order

Change History

05/15/07 07:53:20 changed by darraghbailey

  • attachment buildbot-reconfig-locks-reorder.patch added.

patch to print the correct order

05/15/07 07:55:16 changed by darraghbailey

I haven't tested the patch, but looking at the preceeding code I believed it was safe to assume that the new settings come from setup and the old from self.

10/01/07 13:05:16 changed by warner

  • milestone set to 0.8.0.