TerminateProcess fails in buildbot_service.py

[griels]

buildbot_service.py sometimes fails to kill the Buildbot process:

Event Type: Warning Event Source: BuildBot Event Category: None Event ID: 255 Date: 23/11/2008 Time: 23:00:44 User: N/A Computer: DOGBOLTER Description: BuildBot process at u'c:\\ProsodyTest?\\BuildBot\\build-master' failed to terminate - killing it

Event Type: Error Event Source: BuildBot Event Category: None Event ID: 3 Date: 23/11/2008 Time: 23:00:49 User: N/A Computer: DOGBOLTER Description: The instance's SvcRun?() method failed

File "C:\Python24\lib\site-packages\win32\lib\win32serviceutil.py", line 785, in SvcRun?

self.SvcDoRun?()

File "C:\python24\scripts\buildbot_service.py", line 274, in SvcDoRun?

win32api.TerminateProcess?(h, 3)

pywintypes.error: (5, 'TerminateProcess?', 'Access is denied.')

Using Python 2.4 on a Windows XP build-master.

[griels]

The script is launched from a Scheduled Task run with local Administrator privileges. Buildbot is restarted on a daily basis by this script and it usually works - perhaps this is because Buildbot normally shuts down cleanly within the 3000ms timeout, so the TerminateProcess? command is not required.

I checked into TerminateProcess? bugs/issues and didn't find much other than this:

 http://objectmix.com/python/17383-trouble-killing-process-windows.html

Which suggests maybe there are some security issues with brute-force-killing processes, so maybe this is more of a Windows/win32api problem than an issue with the buildbot_service script?