Ticket #378 (new defect)

Opened 2 months ago

force'd builds from irc don't shout unless specific event happens

Reported by: dannyb Assigned to:
Priority: major Milestone: undecided
Component: statusplugins Version: 0.7.9
Keywords: Cc:

Description

Forced builds from irc create an ircbuildrequest that calls parent.buildFinished when done.

buildFinished has this code:

if not self.notify_for('finished', 'failed', 'success', 'exception', 'failedToSuccess', 'successToFailed'):

return

Thus, if you don't have a specific notify set, a forced irc build will never tell you when it is finished.

This is a regression from previous versions.

The easiest way to fix it is to change IRCBuildRequest to do:

d.addCallback(self.parent.watchedBuildFinished)

instead of

d.addCallback(self.parent.buildFinished)

This causes it to shout no matter what.