Ticket #367 (new defect)

Opened 1 month ago

Last modified 1 month ago

buildbot sighup fails if a LockAccess object is used instead of a Lock object for builder['locks']

Reported by: tolsen718 Assigned to:
Priority: major Milestone: undecided
Component: configuration Version: 0.7.9
Keywords: Cc:

Description

builder.py is trying to access the attribute name which doesn't exist on LockAccess? objects 

sending SIGHUP to process 6745
2008-10-10 19:48:30+0000 [-] loading configuration from /home/buildmaster/master/master.cfg
2008-10-10 19:48:31+0000 [-] configuration update started
2008-10-10 19:48:31+0000 [-] Unhandled error in Deferred:
2008-10-10 19:48:31+0000 [-] Unhandled Error
        Traceback (most recent call last):
          File "/usr/local/lib/python2.4/site-packages/buildbot-0.7.9-py2.4.egg/buildbot/master.py", line 469, in loadTheConfigFile
            self.loadConfig(f)
          File "/usr/local/lib/python2.4/site-packages/buildbot-0.7.9-py2.4.egg/buildbot/master.py", line 717, in loadConfig
            d.addCallback(lambda res: self.loadConfig_Builders(builders))
          File "/usr/local/lib/python2.4/site-packages/Twisted-8.1.0-py2.4-linux-x86_64.egg/twisted/internet/defer.py", line 195, in addCallback
            callbackKeywords=kw)
          File "/usr/local/lib/python2.4/site-packages/Twisted-8.1.0-py2.4-linux-x86_64.egg/twisted/internet/defer.py", line 186, in addCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/usr/local/lib/python2.4/site-packages/Twisted-8.1.0-py2.4-linux-x86_64.egg/twisted/internet/defer.py", line 328, in _runCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/usr/local/lib/python2.4/site-packages/buildbot-0.7.9-py2.4.egg/buildbot/master.py", line 717, in <lambda>
            d.addCallback(lambda res: self.loadConfig_Builders(builders))
          File "/usr/local/lib/python2.4/site-packages/buildbot-0.7.9-py2.4.egg/buildbot/master.py", line 823, in loadConfig_Builders
            elif old.compareToSetup(data):
          File "/usr/local/lib/python2.4/site-packages/buildbot-0.7.9-py2.4.egg/buildbot/process/builder.py", line 325, in compareToSetup
            oldlocks = [(lock.__class__, lock.name)
        exceptions.AttributeError: LockAccess instance has no attribute 'name'

Change History

10/10/08 12:55:23 changed by tolsen718

  • summary changed from buildbot sighup fails if a LockAccess object is used instead of a Lock object in for builder['locks'] to buildbot sighup fails if a LockAccess object is used instead of a Lock object for builder['locks'].