The Test step is modifying a class-level list in place (with append), and as
a result, each time a build has no test results, all builds which use a Test
step will have an increasing number of copies of "no test results" appear in
their descriptions. Oops.
The fix is the following patch:
--- old-TRUNK/buildbot/steps/shell.py 2008-09-17 11:36:01.000000000 -0700
+++ new-TRUNK/buildbot/steps/shell.py 2008-09-17 11:36:01.000000000 -0700
@@ -116,9 +116,9 @@
"""
if done and self.descriptionDone is not None:
- return self.descriptionDone
+ return list(self.descriptionDone)
if self.description is not None:
- return self.description
+ return list(self.description)
properties = self.build.getProperties()
words = self.command
@@ -401,8 +401,6 @@
description.append('%d warnings' % warnings)
if failed:
description.append('%d failed' % failed)
- else:
- description.append("no test results")
return description
class PerlModuleTest(Test):
(I removed the append("no test results") call because a lot of installations
use the Test step without a test parser, and "no test results" is not really
adding a lot of information.)
![[Buildbot Logo]](/trac/chrome/site/header-text-transparent.png)
