Ticket #330 (assigned defect)

Opened 4 months ago

Last modified 2 months ago

Call to getResult instead of getResults in Contact

Reported by: RobotAdam Assigned to: nhemingway (accepted)
Priority: minor Milestone: undecided
Component: statusplugins Version: 0.7.8
Keywords: review Cc:

Description

I was investigating why I couldn't get mail delivery to work, and found this traceback in twisted.log: 

        Traceback (most recent call last):
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/buildbot-0.7.8-py2.4.egg/buildbot/process/base.py", line 576, in buildFinished
            self.build_status.buildFinished()
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/buildbot-0.7.8-py2.4.egg/buildbot/status/builder.py", line 1174, in buildFinish
ed
            w.callback(self)
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/Twisted-8.1.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 243, in cal
lback
            self._startRunCallbacks(result)
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/Twisted-8.1.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 312, in _st
artRunCallbacks
            self._runCallbacks()
        --- <exception caught here> ---
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/Twisted-8.1.0-py2.4-linux-i686.egg/twisted/internet/defer.py", line 328, in _ru
nCallbacks
            self.result = callback(self.result, *args, **kw)
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/buildbot-0.7.8-py2.4.egg/buildbot/status/builder.py", line 1696, in _buildFinis
hed
            w.buildFinished(name, s, results)
          File "/export/play/brett/btrunk/dev/dotorg/sites/cgi-lib/python/buildbot/lib/python2.
4/site-packages/buildbot-0.7.8-py2.4.egg/buildbot/status/words.py", line 340, in buildFinished
            prevResult = prevBuild.getResult()
        exceptions.AttributeError: BuildStatus instance has no attribute 'getResult'

Looking through the code (including that method), it seems that the call should be to getResults. The change worked for me, and all tests pass that passed before. The attached patch patches darcs head.

Attachments

getresult.patch (0.6 kB) - added by RobotAdam on 08/12/08 11:57:55.
330.patch (5.7 kB) - added by nhemingway on 09/24/08 14:42:57.

Change History

08/12/08 11:57:55 changed by RobotAdam

  • attachment getresult.patch added.

09/24/08 14:42:16 changed by nhemingway

  • keywords set to review.

Resolved by commits aaf87c5f39d442cea5d4949ef38036a6c2e1634f and 6b3cf83538666098f3dd7446a33775b700c242be to neilh_master in buildbot at repo.or.cz. Also attached as 330.patch

09/24/08 14:42:57 changed by nhemingway

  • attachment 330.patch added.

09/24/08 14:44:49 changed by nhemingway

  • owner set to nhemingway.
  • status changed from new to assigned.