Ticket #292 (closed defect: fixed)

Opened 2 years ago

Last modified 5 months ago

Buildbot generates incorrect waterfall xhtml

Reported by: DevUrandom Owned by:
Priority: major Milestone: 0.8.0
Version: 0.7.7 Keywords:
Cc:

Description

Buildbot claims to produce xhtml 1.0 strict, but at least the waterfall page is not correct xhtml. The main offenders are the old html style-hints in the content-markup (like "bgcolor", etc) and cdata directly in <body> (without surrounding <div>, <p>, etc).

It would be good if the style-hints could be entirely moved from the markup to a stylesheet.

A very nice addition would be if the page would contain more <div> elements with ids like "header", "footer", and so on. This would allow the page to be more customizable.

Change History

Changed 19 months ago by dustin

  • milestone changed from undecided to 0.7.+

divurandom: sounds good -- want to send a patch?

Changed 5 months ago by marcusl

I added a validation test after rewriting the web status to jinja. It passes and checks against the official w3c DTD schemas.

Could you recheck this against the current 0.8 and see if there's anything specific that needs fixing?

Changed 5 months ago by marcusl

  • status changed from new to closed
  • resolution set to fixed

The doctype is (after the jinjafication) XHTML transitional, which should be more correct.

The customization part works for sure. Closing this as fixed for now (as the output validates) and I'll leave it to someone else to rewrite the XHTML to the strict doctype.

Changed 5 months ago by marcusl

  • milestone changed from 0.8.+ to 0.8.0
Note: See TracTickets for help on using tickets.