Ticket #261 (closed defect: fixed)

Opened 4 months ago

Last modified 2 months ago

SVNPoller fails to recognise a branch deletion

Reported by: nhemingway Assigned to: nhemingway
Priority: minor Milestone: 0.7.8
Component: changesources Version: 0.7.7
Keywords: Cc: dustin

Description

If a SVN branch is deleted it is detected (correctly) as a change by SVNPoller. However, it then blindly creates a Change without taking into account the fact that the Change will attempt to checkout and build something that is no longer there.

Attachments

buildbot_branch_deletions.diff (5.0 kB) - added by nhemingway on 05/03/08 14:28:19.
Patch to resolve #261

Change History

05/01/08 23:50:58 changed by nhemingway

  • status changed from new to assigned.

05/03/08 14:28:19 changed by nhemingway

  • attachment buildbot_branch_deletions.diff added.

Patch to resolve #261

05/03/08 14:40:12 changed by nhemingway

  • status changed from assigned to new.

The patch I've just attached (buildbot_branch_deletions.diff) has svnpoller checking whether the change reported by SVN is a branch deletion. If it is, a buildbot Change is not created.

05/16/08 13:46:12 changed by dustin

  • cc set to dustin.

I can't really see why someone would want buildbot to handle this sort of situation, but this does seem a better way to handle it.

In the dev tree as #261:buildbot_branch_deletions.diff

05/17/08 01:13:46 changed by nhemingway

The "standard" or "documented" use for buildbot is to build the same branch on multiple architectures. Our app is perl running in house on a single target platform. But we do have multiple project and ticket branches separate from trunk. So we use bb to have a builder perl branch. All fine until someone deletes their ticket branch (having merged it back to trunk) at which point bb fires off a (pointless) build for a branch that's no longer there!

05/17/08 05:59:22 changed by dustin

got it -- apparently I wasn't thinking too hard. Thanks!

05/26/08 16:50:48 changed by dustin

  • status changed from new to closed.
  • resolution set to fixed.

pushed to brian's tree

07/15/08 12:25:12 changed by dustin

  • milestone changed from undecided to 0.7.8.