Ticket #261 (closed defect: fixed)

Opened 23 months ago

Last modified 20 months ago

SVNPoller fails to recognise a branch deletion

Reported by: nhemingway Owned by: nhemingway
Priority: minor Milestone: 0.7.8
Version: 0.7.7 Keywords:
Cc: dustin

Description

If a SVN branch is deleted it is detected (correctly) as a change by SVNPoller. However, it then blindly creates a Change without taking into account the fact that the Change will attempt to checkout and build something that is no longer there.

Attachments

buildbot_branch_deletions.diff Download (5.0 KB) - added by nhemingway 23 months ago.
Patch to resolve #261

Change History

Changed 23 months ago by nhemingway

  • status changed from new to assigned

Changed 23 months ago by nhemingway

Patch to resolve #261

Changed 23 months ago by nhemingway

  • status changed from assigned to new

The patch I've just attached (buildbot_branch_deletions.diff) has svnpoller checking whether the change reported by SVN is a branch deletion. If it is, a buildbot Change is not created.

Changed 22 months ago by dustin

  • cc dustin added

I can't really see why someone would want buildbot to handle this sort of situation, but this does seem a better way to handle it.

In the dev tree as #261:buildbot_branch_deletions.diff

Changed 22 months ago by nhemingway

The "standard" or "documented" use for buildbot is to build the same branch on multiple architectures. Our app is perl running in house on a single target platform. But we do have multiple project and ticket branches separate from trunk. So we use bb to have a builder perl branch. All fine until someone deletes their ticket branch (having merged it back to trunk) at which point bb fires off a (pointless) build for a branch that's no longer there!

Changed 22 months ago by dustin

got it -- apparently I wasn't thinking too hard. Thanks!

Changed 22 months ago by dustin

  • status changed from new to closed
  • resolution set to fixed

pushed to brian's tree

Changed 20 months ago by dustin

  • milestone changed from undecided to 0.7.8
Note: See TracTickets for help on using tickets.