Ticket #251 (assigned enhancement)

Opened 8 months ago

Last modified 7 months ago

Colour is a presentational attribute, but it's set in many different places

Reported by: nhemingway Assigned to: warner (accepted)
Priority: minor Milestone: 0.8.0
Component: other Version: 0.7.6
Keywords: Cc: nhemingway

Description

The colour used to present steps is set in many different places, most of which have no other presentational function. Standard practice is to separate presentation from function.

The waterfall seems to not depend on the colour set for a step (relying only on CSS) The statuslog is text only so colour is irrelevant (?) The statusgui does seem to depend on the step's colour, but that could be set more simply based on the step's result The debugclient seems to have no function that would involve colour.

If I have any of this wrong (wildly wrong?), pls let me know.

I have created the attached (diff -u) patch, which seems to work for both of the above clients that use colour and passes all of the tests.

Attachments

buildbot_colors.diff (30.1 kB) - added by nhemingway on 04/22/08 12:45:14.
darcs diff -u removing color from all but presentation code

Change History

04/22/08 12:45:14 changed by nhemingway

  • attachment buildbot_colors.diff added.

darcs diff -u removing color from all but presentation code

04/28/08 13:24:04 changed by warner

  • owner changed from nhemingway to warner.
  • status changed from new to assigned.
  • milestone changed from undecided to 0.7.8.