Build properties "revision" and "got_revision" not populated for P4

[tonnis]

It seems that the Build properties "revision" and "got_revision" are not populated for P4 (Perforce). I am not super Python, nor buildbot literate, but I cannot find where the "revision" property is populated onto the build instance by SourceBase? or *any* of its descendant classes, and it is not being populated when I use ...WithProperties?("%(revision)s") for ShellCommands? executed after the P4 Step. (The missing "got_revision" is also mentioned in Bug #127)

[tonnis]

Patch (diff) for buildbot/slave/commands.py

[tonnis]

Here is a patch that does the right thing for got_revision. It follows the pattern used in the Subversion adapter by making a subsequent ShellCommand? via the callback used by parseGotRevision. This output of the command is parsed to get the revision (Change List) number.

'This patch applies to the 0.7.7 version sources. The drop down on this Ticket does not list 0.7.7 as an option.'

[warner]

seems reasonable. what sort of test coverage could we manage on this? let's take a look at test_vc.py and see if it does any sorts of checks on got_revision.

[dustin]

committed (in modified form) as a patch by jgraff: http://github.com/jgraff/buildbot/commit/ab61561c9bc98d69b64db2b3bdb5c05dce969264