Ticket #226 (closed defect: fixed)

Opened 8 months ago

Last modified 2 months ago

'buildbot restart' shouldn't fail when buildbot is not running

Reported by: bhearsum Assigned to: bhearsum
Priority: minor Milestone: 0.7.9
Component: other Version: 0.7.7
Keywords: review, devtree Cc: warner, dustin

Description

I'm not sure how others feel about this but to me it makes sense for 'buildbot restart' to _always_ end with Buildbot starting (assuming valid configuration, etc.), even if Buildbot isn't running.

Attachments

nofailRestart.diff (1.8 kB) - added by bhearsum on 04/30/08 05:47:04.
make 'buildbot restart' work when buildbot is not running
restart-docs.diff (0.8 kB) - added by bhearsum on 07/17/08 06:13:33.
updated restart docs

Change History

04/30/08 05:47:04 changed by bhearsum

  • attachment nofailRestart.diff added.

make 'buildbot restart' work when buildbot is not running

04/30/08 05:47:19 changed by bhearsum

  • status changed from new to assigned.

07/16/08 07:34:02 changed by bhearsum

  • cc set to warner, dustin.
  • version set to 0.7.7.

Any change this will make 0.7.8?

07/16/08 10:35:08 changed by warner

  • milestone changed from undecided to 0.7.8.

looks reasonable to me.. we could use some docs updates, though, and a test would be great, but I won't hold up the patch for those.

07/17/08 06:13:33 changed by bhearsum

  • attachment restart-docs.diff added.

updated restart docs

08/30/08 13:20:08 changed by dustin

  • keywords set to review.

08/30/08 14:08:13 changed by dustin

  • keywords changed from review to review, devtree.

09/03/08 15:23:48 changed by warner

looks good to me

09/16/08 11:52:59 changed by warner

  • status changed from assigned to closed.
  • resolution set to fixed.

applied in buildbot-0.7.9 . In the future, please include the ticket number (like "#226") in the checkin comments.. that will help me manage the release notes better.