Ticket #207 (assigned defect)

Opened 8 months ago

Last modified 2 months ago

"offline" should not be red

Reported by: zooko Assigned to: zooko (accepted)
Priority: major Milestone: undecided
Component: other Version: 0.7.6
Keywords: Cc: zooko, nhemingway

Description

Red should be reserved for bugs in the source code under test.

Change History

03/21/08 16:58:01 changed by warner

sounds good to me. But.. what color should it be?

04/05/08 07:03:25 changed by zooko

I'm sorry, I didn't notice your comment until just now. It would be good if the buildbot trac would e-mail me when comments are added to tickets that I am involved in.

Anyway, I'm not sure if I am being lured into a Douglas Adams joke here, but how about orange?

04/05/08 07:32:27 changed by zooko

By the way, the reason that I revisited this ticket today is that the allmydata.org buildbot has a red column due to a bug in the allmydata source code, and I want people to notice that one, and I'm afraid that the presence of three others columns that are red due to being offline will make it harder for them to notice the important one.

04/06/08 15:13:02 changed by bhearsum

IIRC the colours are used as following on the Waterfall: Green: OK Yellow: Building/In Progress Orange: Test Failed Red: Busted Purple: Internal Error

I can't see "buildslave missing" fitting into any of those very well. Maybe it should just be white with 'buildslave missing' in bold, or something similar. If a colour is used for it I think it should be a lighter colour, since a missing buildslave is sometimes OK. Maybe cyan or pink (these are both defined CSS colours, too)?

04/10/08 15:28:59 changed by zooko

  • cc set to zooko.

04/10/08 15:29:17 changed by zooko

Good idea, bhearsum -- white or light sounds good to me.

04/25/08 08:35:18 changed by nhemingway

  • cc changed from zooko to zooko, nhemingway.

I'm working on #251 which removes all colours setting from non-presentation code, which may relate to this ticket. I have noticed that as far as the WebStatus? is concerned, everything is controlled through CSS, so setting CSS attributes for the offline class will resolve this ticket. Is that what you mean?

04/25/08 09:07:18 changed by zooko

Yes! Thank you!

http://allmydata.org/buildbot-tahoe-prod/waterfall?show_events=false

07/31/08 14:07:08 changed by nhemingway

zooko,

if your problem is solved, could you close this ticket pls

thx

07/31/08 14:18:59 changed by zooko

  • owner set to zooko.
  • status changed from new to assigned.

I propose to make the default css use grey for offline:

buildbot/status/web/classic.css@613#L14

If no-one objects, I'll try using my previously untested BuildBot? Source Commit Power to make it so.

09/19/08 12:39:10 changed by ashcrow

Grey sounds like it is a good choice to me.