Ticket #181 (new defect)

Opened 10 months ago

Last modified 3 months ago

hgbuildbot fails to signal merges properly causing incorrect builds

Reported by: dsallings Assigned to: dustin
Priority: major Milestone: undecided
Component: changesources Version: 0.7.6
Keywords: mercurial Cc:

Description

I'm not entirely sure whether the fault lies in PBChangeSource or hgbuildbot.py, but I've worked around it in the latter.

Basically, when a changeset comes in with no files, buildbot doesn't consider it and will build from a changeset that arrived before it. This is very undesirable.

To work around this, I've special-cased a no-file changeset to say it changed the file merge which at least makes it work in my environment.

I don't like this all that much, but it's a discussion point.

Attachments

hg-buildbot-merge.diff (0.8 kB) - added by dsallings on 02/08/08 13:56:26.
hgbuildbot.patch (1.9 kB) - added by paulegan on 08/25/08 10:03:15.
Refactor and bug fixes for hgbuildbot.py

Change History

02/08/08 13:56:26 changed by dsallings

  • attachment hg-buildbot-merge.diff added.

08/25/08 10:03:15 changed by paulegan

  • attachment hgbuildbot.patch added.

Refactor and bug fixes for hgbuildbot.py

08/25/08 10:03:35 changed by paulegan

  • owner set to dustin.

I've been using a similar patch to address this issue. It seems that the git change source has the same problem (and suggested fix): #249. I've attached a patch which includes a fix for this issue (and #328) as well as refactoring the code to make it a little more clear.