Ticket #178 (assigned enhancement)

Opened 10 months ago

Last modified 1 month ago

extraRecipients in MailNotifiers should be CC'ed, not in the TO: list

Reported by: soundgeek Assigned to: warner (accepted)
Priority: minor Milestone: 0.8.0
Component: statusplugins Version: 0.7.6
Keywords: MailNotifier Cc:

Description

As the buildbot sheriff, I am in the extraRecipients list for all of my MailNotifiers?. Because of this, I usually can't tell if I'm being sent the "build failed" email b/c *I* broke the build or just because I'm on the extra recipients list. Thus, I have to manually check which is usually a waste of time. It'd be great if the extra recipients list was CC'ed instead of being on the TO: list. The notifier does appear to merge my name if I was at fault (i.e. it's only in the TO: list once) so this does require some extra smarts if I was actually to blame.

I took a look at the code in the MailNotifier? class but I don't understand Deferreds so I wasn't quite sure how to do the change. I could also see a case where not everybody would want to use the CC: list so some extra option might be needed.

Attachments

mailCC.patch (1.3 kB) - added by cmetcalf on 10/17/08 22:52:03.
0002-Add-email-validation-and-TO-CC.patch (3.2 kB) - added by cmetcalf on 11/03/08 20:22:45.
Tested patch to do this

Change History

04/28/08 13:31:26 changed by warner

  • owner set to warner.
  • status changed from new to assigned.
  • milestone changed from undecided to 0.7.8.

sounds like a good idea.. I'll look into it.

10/17/08 22:51:46 changed by cmetcalf

I think this is pretty simple. This patch goes with my fix for #378.

10/17/08 22:52:03 changed by cmetcalf

  • attachment mailCC.patch added.

11/03/08 20:22:45 changed by cmetcalf

  • attachment 0002-Add-email-validation-and-TO-CC.patch added.

Tested patch to do this