Ticket #162 (closed defect: fixed)

Opened 8 months ago

Last modified 2 months ago

make public_html directory configurable

Reported by: dustin Assigned to: dustin
Priority: minor Milestone: undecided
Component: statusplugins-web Version: 0.7.7
Keywords: Cc: ijon

Description

I'm not sure if I'm going to use this, but it seems like it will be generally useful. It adds a public_html= option to the WebStatus? constructor, allowing the user to configure the web directory to something other than a subdirectory of the basedir, if desired. I'm using this to serve html out of a subdirectory of our svn tree, but I can see that others might use it to serve several buildmasters out of the same HTML tree, for example.

Attachments

pubhtml.patch (4.3 kB) - added by dustin on 12/28/07 09:44:45.
public_html.patch
webstatus-public-html-default.patch (0.5 kB) - added by ijon on 07/07/08 04:15:45.
adds back default value of public_html

Change History

12/28/07 09:44:45 changed by dustin

  • attachment pubhtml.patch added.

public_html.patch

02/17/08 10:17:28 changed by dustin

  • owner set to dustin.

I need to add some documentation to this :)

04/28/08 14:51:11 changed by warner

what about using a symlink? It isn't a bad feature, per se, but I'd like to avoid adding options that aren't really going to be used.

06/28/08 11:37:24 changed by dustin

The symlink is awkward, because it has to be set up *after* the "create" operation is complete, and thus removes that aspect of the configuration from master.cfg.

I use lots of "local" installations of our buildbot config for various testing purposes, so this becomes important for my purposes. I don't think it adds a significant amount of additional complexity..

Added in my repo as #162:pubhtml.patch

06/28/08 11:38:23 changed by dustin

  • status changed from new to closed.
  • resolution set to fixed.

07/07/08 04:14:02 changed by ijon

  • status changed from closed to reopened.
  • version changed from 0.7.6 to 0.7.7.
  • resolution deleted.

This breaks my buildbot installation (on upgrade from 0.7.6+dustin-... to buildbot-0.7.7-dustin-20080701) -- because WebStatus now can't work without explicit specification of public_html parameter.

07/07/08 04:15:45 changed by ijon

  • attachment webstatus-public-html-default.patch added.

adds back default value of public_html

07/07/08 04:46:14 changed by ijon

  • cc set to ijon.

07/07/08 08:57:47 changed by dustin

This works too: 

diff -rN -u old-dustin/buildbot/status/web/baseweb.py new-dustin/buildbot/status/web/baseweb.py
--- old-dustin/buildbot/status/web/baseweb.py   2008-07-07 11:55:30.000000000 -0400
+++ new-dustin/buildbot/status/web/baseweb.py   2008-07-07 11:55:30.000000000 -0400
@@ -360,7 +360,7 @@
     # all the changes).
 
     def __init__(self, http_port=None, distrib_port=None, allowForce=False,
-                       public_html=None):
+                       public_html="public_html"):
         """Run a web server that provides Buildbot status.
 
         @type  http_port: int or L{twisted.application.strports} string

sorry about that!

This is in the devel repository, and I've built a new tarball.

07/07/08 08:58:11 changed by dustin

  • status changed from reopened to closed.
  • resolution set to fixed.