Ticket #145 (new enhancement)

Opened 1 year ago

Last modified 8 months ago

Patch: split OneLineMixin.make_line

Reported by: amax_snaplogic Assigned to:
Priority: major Milestone: 0.8.0
Component: statusplugins-web Version: 0.7.6
Keywords: Cc:

Description

Hi,

This patch refactors OneLineMixin?.make_line(), splitting in into two methods: one that gathers all the data needed for a build (get_line_values), and one that takes that data, and renders it into an HTML line (make_line).

The win here is that someone can customize the HTML display of a report more easily by subclassing OneLineMixin? (or more likely, one of its subclasses) and overridding make_line(). One could before, of course, but now they can reuse the data-gathering code by calling get_line_values().

Attachments

OneLineMixin.make_line.patch (1.1 kB) - added by amax_snaplogic on 11/22/07 14:13:28.
Patch to split OneLineMixin?.make_line

Change History

11/22/07 14:13:28 changed by amax_snaplogic

  • attachment OneLineMixin.make_line.patch added.

Patch to split OneLineMixin?.make_line

03/22/08 13:03:33 changed by warner

  • milestone changed from undecided to 0.7.8.

cool.