Ticket #10 (assigned enhancement)

Opened 2 years ago

Last modified 1 week ago

Builders should be defined as instances, not as a dictionary

Reported by: warner Assigned to: warner (accepted)
Priority: major Milestone: 0.8.0
Component: configuration Version: 0.7.5
Keywords: Cc: bhearsum@mozilla.com

Description

The c['builders'] specification is the last one in master.cfg that is defined with a dictionary. I think it would be much clearer if it were defined as an instance. So instead of: 

    b1 = {"name": "svn-hello",
          "slavename": "bot1",
          "builddir": "svn-hello",
          "factory": factory.BuildFactory(steps),
          }
    c['builders'].append(b1)

you would do: 

    b1 = Builder("svn-hello", "bot1", factory.BuildFactory(steps))
    Builders.append(b1)

(assuming that #9 was implemented)

Also, the "builddir" argument should go away, and just use the builder name. Having to specify a separate directory is annoying. It might be nice to add a separate "verbose builder name" argument, though, since the normal builder name gets used as a directory name and thus can't have slashes (and really doesn't want to have spaces).

Change History

09/29/07 02:08:10 changed by warner

  • version set to 0.7.5.
  • milestone set to 0.7.7.

09/29/07 02:29:07 changed by warner

  • status changed from new to assigned.

12/21/07 19:55:32 changed by warner

  • milestone changed from 0.7.7 to 0.7.8.

no progress on this yet, bumping to 0.7.8

03/17/08 17:29:37 changed by warner

After finishing this, implement #119 (builder descriptions)

03/19/08 10:10:45 changed by bhearsum

  • cc set to bhearsum@mozilla.com.

04/28/08 13:34:29 changed by warner

also see #148

05/02/08 16:22:08 changed by warner

  • milestone changed from 0.7.8 to 0.7.9.

not happening for 0.7.8, pushing it out.

11/14/08 01:02:35 changed by marcusl

Marked #148 as duplicate of this.