{5} Assigned, Active Tickets by Owner (Full Description) (26 matches)

On mode=copy, Buildbot is using cp -rp for copying source to build, copying whole history of repository.

Using hg archive source build would copy only tip, speeding up whole process a lot for bigger repositories.

I'm thinking this can be implemented as an optional function to pass to MailNotifier?, that would be like buildMessage -- but only deal with formatting (no deferred objects).

Something I'd like to be able to do is split out different sets of operations into different factories. For example, BuildProducingFactory?, BuildUploadingFactory?, TestFactory?, and various others. In many cases it is desirable to combine these operations into a single builder. I'd like to be able to do the following things with a BuildFactory?: * add a step anywhere in BuildFactory?.steps. * add a method that will combine two BuildFactory?'s into one

I think it's a fairly common use case that all of a Builder's BuildSteps? require the same environment variables. I propose that the Builder 'setup' should be able to take in a dict of environment variables and pass it along to all BuildSteps? that require/support it (ie. it wouldn't pass it to something like FileDownload?).

I'd be happy to code this up myself assuming it is wanted.

The buildbot slave default timeout can be too short for us. Sometimes, 5sec isnt always enough, and we get following:

% cltbld$ buildbot start /Users/cltbld/macosx-slave1

Following twistd.log until startup finished.. The buildmaster took more than 5 seconds to start, so we were unable to confirm that it started correctly. Please 'tail twistd.log' and look for a line that says 'configuration update complete' to verify correct startup.

%

... even though slave started "normally", responds fine to pings from buildbot master, and does handle jobs just fine.

usepty is an argument to buildbot create-slave. The correct place to configure this is on a per-step basis though (perhaps at the ShellCommand level, but maybe there's a better "thing which runs a child process" central location).

Certain BuildSteps (well, ShellCommand at least, thanks to ticket #43) allow you pass a WithProperties object as workdir. FileUpload and FileDownload do not.

Here's my example:

workdir = shell.WithProperties("build.%s", "buildnumber")
...
f2 = factory.BuildFactory()
f2.addStep(transfer.FileUpload(
    slavesrc="file",
    masterdest="uploaded-file",
    workdir=workdir,
    ))

When I run the build in question, the upload step dies with this exception:

Traceback from remote host -- Traceback (most recent call last):
  File "/usr/local/Intelerad/3rd_Party/python-2.5/lib/python2.5/site-packages/twisted/spread/pb.py", line 847, in _recvMessage
    netResult = object.remoteMessageReceived(self, message, netArgs, netKw)
  File "/usr/local/Intelerad/3rd_Party/python-2.5/lib/python2.5/site-packages/twisted/spread/flavors.py", line 119, in remoteMessageReceived
    state = method(*args, **kw)
  File "/home/gward/lib/python/buildbot/slave/bot.py", line 171, in remote_startCommand
    d = self.command.doStart()
  File "/home/gward/src/buildbot/buildbot/slave/commands.py", line 629, in doStart
    d = defer.maybeDeferred(self.start)
--- <exception caught here> ---
  File "/usr/local/Intelerad/3rd_Party/python-2.5/lib/python2.5/site-packages/twisted/internet/defer.py", line 107, in maybeDeferred
    result = f(*args, **kw)
  File "/home/gward/src/buildbot/buildbot/slave/commands.py", line 716, in start
    os.path.expanduser(self.filename))
  File "/var/tmp/python2.5-intelerad-2.5.1-root/usr/local/Intelerad/3rd_Party/python-2.5/lib/python2.5/posixpath.py", line 60, in join
    if b.startswith('/'):
exceptions.AttributeError: Unpersistable instance has no attribute 'startswith'

    def doCopy(self, res):
        # now copy tree to workdir
        fromdir = os.path.join(self.builder.basedir, self.srcdir)
        todir = os.path.join(self.builder.basedir, self.workdir)
        if runtime.platformType != "posix":
            self.sendStatus({'header': "Since we're on a non-POSIX platform, we're not going to try to execute cp in a subprocess, but instead 
use shutil.copytree(), which will block until it is complete.  fromdir: %s, todir: %s\n" % (fromdir, todir)})
            shutil.copytree(fromdir, todir)
            return defer.succeed(0)
        command = ['cp', '-r', '-p', fromdir, todir]
        c = ShellCommand(self.builder, command, self.builder.basedir,
                         sendRC=False, timeout=self.timeout)

The c['builders'] specification is the last one in master.cfg that is defined with a dictionary. I think it would be much clearer if it were defined as an instance. So instead of:

    b1 = {"name": "svn-hello",
          "slavename": "bot1",
          "builddir": "svn-hello",
          "factory": factory.BuildFactory(steps),
          }
    c['builders'].append(b1)

you would do:

    b1 = Builder("svn-hello", "bot1", factory.BuildFactory(steps))
    Builders.append(b1)

(assuming that #9 was implemented)

Also, the "builddir" argument should go away, and just use the builder name. Having to specify a separate directory is annoying. It might be nice to add a separate "verbose builder name" argument, though, since the normal builder name gets used as a directory name and thus can't have slashes (and really doesn't want to have spaces).

The du command completes successfully, but the build step fails with this exception:

Traceback (most recent call last):
  File "C:\Python\lib\site-packages\twisted\internet\defer.py", line 182, in addCallbacks
    self._runCallbacks()
  File "C:\Python\lib\site-packages\twisted\internet\defer.py", line 317, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "C:\Python\lib\site-packages\twisted\internet\defer.py", line 239, in callback
    self._startRunCallbacks(result)
  File "C:\Python\lib\site-packages\twisted\internet\defer.py", line 304, in _startRunCallbacks
    self._runCallbacks()
--- <exception caught here> ---
  File "C:\Python\lib\site-packages\twisted\internet\defer.py", line 317, in _runCallbacks
    self.result = callback(self.result, *args, **kw)
  File "C:\Python\Lib\site-packages\buildbot\process\buildstep.py", line 955, in <lambda>
    d.addCallback(lambda res: self.commandComplete(cmd))
  File "C:\Python\Lib\site-packages\buildbot\steps\shell.py", line 238, in commandComplete
    out = cmd.log.getText()
exceptions.AttributeError: RemoteShellCommand instance has no attribute 'log'

As the buildbot sheriff, I am in the extraRecipients list for all of my MailNotifiers?. Because of this, I usually can't tell if I'm being sent the "build failed" email b/c *I* broke the build or just because I'm on the extra recipients list. Thus, I have to manually check which is usually a waste of time. It'd be great if the extra recipients list was CC'ed instead of being on the TO: list. The notifier does appear to merge my name if I was at fault (i.e. it's only in the TO: list once) so this does require some extra smarts if I was actually to blame.

I took a look at the code in the MailNotifier? class but I don't understand Deferreds so I wasn't quite sure how to do the change. I could also see a case where not everybody would want to use the CC: list so some extra option might be needed.

Red should be reserved for bugs in the source code under test.

Thu Apr 17 14:02:59 MDT 2008  zooko@zooko.com
  * setup: use the console_scripts feature of setuptools for buildbot, darcs_buildbot, and buildbot_service
  Also use the find_packages() feature of setuptools instead of an explicit list of packages in setup.py.  Also make contrib and contrib/windows be packages (by adding __init__.py files to them) so that they can be imported at run-time by the console scripts.
diff -rN -u old-trunk/contrib/darcs_buildbot.py new-trunk/contrib/darcs_buildbot.py
--- old-trunk/contrib/darcs_buildbot.py	2008-04-17 14:04:21.000000000 -0600
+++ new-trunk/contrib/darcs_buildbot.py	2008-04-17 14:04:21.000000000 -0600
@@ -159,6 +159,9 @@
         f.write(lastchange)
         f.close()
 
-if __name__ == '__main__':
+def main():
     MASTER = sys.argv[1]
     sendChanges(MASTER)
+
+if __name__ == '__main__':
+    main()
diff -rN -u old-trunk/setup.py new-trunk/setup.py
--- old-trunk/setup.py	2008-04-17 14:04:21.000000000 -0600
+++ new-trunk/setup.py	2008-04-17 14:04:21.000000000 -0600
@@ -1,7 +1,6 @@
 #! /usr/bin/env python
 
 import sys, os, re
-from distutils.core import setup
 from buildbot import version
 
 # Path: twisted!cvstoys!buildbot
@@ -32,11 +31,6 @@
 improve.
 """
 
-scripts = ["bin/buildbot"]
-if sys.platform == "win32":
-    scripts.append("contrib/windows/buildbot.bat")
-    scripts.append("contrib/windows/buildbot_service.py")
-
 testmsgs = []
 for f in os.listdir("buildbot/test/mail"):
     if f.endswith("~"):
@@ -64,16 +58,6 @@
         'Topic :: Software Development :: Testing',
         ],
 
-    'packages': ["buildbot",
-              "buildbot.status", "buildbot.status.web",
-              "buildbot.changes",
-              "buildbot.steps",
-              "buildbot.process",
-              "buildbot.clients",
-              "buildbot.slave",
-              "buildbot.scripts",
-              "buildbot.test",
-              ],
     'data_files': [("buildbot", ["buildbot/buildbot.png"]),
                 ("buildbot/clients", ["buildbot/clients/debug.glade"]),
                 ("buildbot/status/web",
@@ -85,7 +69,6 @@
                 ("buildbot/test/mail", testmsgs),
                 ("buildbot/test/subdir", ["buildbot/test/subdir/emit.py"]),
                 ],
-    'scripts ':  scripts,
     'cmdclass': {'install_data': install_data_twisted},
     }
 
@@ -94,9 +77,32 @@
     # to the setup args.
     import setuptools
 except ImportError:
-    pass
+    from distutils.core import setup
+    setup_args['scripts'] = ["bin/buildbot"]
+    if sys.platform == "win32":
+        setup_args['scripts'].append("contrib/windows/buildbot.bat")
+        setup_args['scripts'].append("contrib/windows/buildbot_service.py")
+    setup_args['packages'] = ["buildbot",
+              "buildbot.status", "buildbot.status.web",
+              "buildbot.changes",
+              "buildbot.steps",
+              "buildbot.process",
+              "buildbot.clients",
+              "buildbot.slave",
+              "buildbot.scripts",
+              "buildbot.test",
+              ],
 else:
+    from setuptools import find_packages, setup
     setup_args['install_requires'] = ['twisted >= 2.4.0']
+    setup_args['entry_points'] = {
+        'console_scripts': [
+            'buildbot = buildbot.scripts.runner:run',
+            'buildbot_service = contrib.windows.buildbot_service:HandleCommandLine',
+            'darcs_buildbot = contrib.darcs_buildbot:main'
+            ]
+        }
+    setup_args['packages'] = find_packages()
 
 setup(**setup_args)