Changeset 690

Show
Ignore:
Timestamp:
04/15/08 12:20:22 (9 months ago)
Author:
zooko@zooko.com
Message:

don't create a new missing-timer task if there is already one there
Doing that would mean that the one that is already there will not be cleaned up if the buildslave reattaches before the timer goes off, so this patch probably fixed #211.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved
  • buildbot/buildslave.py

    r653 r690  
    199199        self.botmaster.slaveLost(self) 
    200200        log.msg("BuildSlave.detached(%s)" % self.slavename) 
    201         if self.notify_on_missing and self.parent
     201        if self.notify_on_missing and self.parent and not self.missing_timer
    202202            self.missing_timer = reactor.callLater(self.missing_timeout, 
    203203                                                   self._missing_timer_fired)