Changeset 579

Timestamp:

03/22/08 14:49:21 (10 months ago)

Author:

warner@lothar.com

Message:

slave/commands.py: log more information about stdin and PTYs to the 'headers' section

Files:

• ChangeLog (modified) (1 diff)
• buildbot/slave/commands.py (modified) (1 diff)

ChangeLog

@@ -1 +1 @@
-2008-03-22  Brian Warner  <warner@lothar.com>
+
+        * buildbot/slave/commands.py (ShellCommand): record more
+        information in the 'header' section: how much we write into stdin,
+        do we close stdin, are we using a PTY. There are lingering
+        problems with PTYs and with closing stdin (see #198 and #158).
+        This doesn't fix those problems, but it should provide more
+        information to developers.
-
-        * buildbot/status/client.py: hush pyflakes, log.msg vs log

buildbot/slave/commands.py

@@ -377 +377 @@
-        log.msg(" environment: %s" % (self.environ,))
-        self.sendStatus({'header': msg})
+
+        if self.initialStdin:
+            msg = " writing %d bytes to stdin" % len(self.initialStdin)
+            log.msg(" " + msg)
+            self.sendStatus({'header': msg+"\n"})
+
+        if self.keepStdinOpen:
+            msg = " leaving stdin open"
+        else:
+            msg = " closing stdin"
+        log.msg(" " + msg)
+        self.sendStatus({'header': msg+"\n"})
+
+        msg = " using PTY: %s" % bool(self.usePTY)
+        log.msg(" " + msg)
+        self.sendStatus({'header': msg+"\n"})
-
-        # this will be buffered until connectionMade is called