Changeset 493

Show
Ignore:
Timestamp:
10/10/07 00:22:11 (1 year ago)
Author:
warner@lothar.com
Message:

fix a typo that removed the Stop Build button. Closes #114.

Files:

Legend:

Unmodified
Added
Removed
Modified
Copied
Moved

  • ChangeLog

    r492 r493  
    112007-10-10  Brian Warner  <warner@lothar.com> 
     2 
     3        * buildbot/status/web/build.py (BuildsResource.getChild): fix 
     4        silly typo which prevented the Build page from ever offering 
     5        control options like 'Stop Build'. Thanks to Aaron Hsieh for the 
     6        catch. Closes #114. 
     7        * buildbot/test/test_webparts.py (Webparts._do_page_tests): it'd 
     8        be nice to test this 
    29 
    310        * buildbot/__init__.py (version): bump to 0.7.6+ while between 

  • buildbot/status/web/build.py

    r472 r493  
    259259            build_status = self.builder_status.getBuild(num) 
    260260            if build_status: 
    261                 build_control = None 
    262261                if self.builder_control: 
    263                     builder_control = self.builder_control.getBuild(num) 
     262                    build_control = self.builder_control.getBuild(num) 
     263                else: 
     264                    build_control = None 
    264265                return StatusResourceBuild(build_status, build_control, 
    265266                                           self.builder_control) 

  • buildbot/test/test_webparts.py

    r462 r493  
    128128        # require causing a build to complete. 
    129129        #d.addCallback(self._check, "builders/builder1/builds/1", "") 
     130        # it'd be nice to assert that the Build page has a "Stop Build" button 
    130131        #d.addCallback(self._check, "builders/builder1/builds/1/steps", "") 
    131132        #d.addCallback(self._check,