Ticket #138: 0002-Code-cleanup.patch

buildbot/slave/bot.py

@@ -37 +37 @@
     """
     def __init__(self, builder):
         self.builder = builder
-    
+
 class SlaveBuilder(pb.Referenceable, service.Service):
 
     """This is the local representation of a single Builder: it handles a
@@ -134 +134 @@
         self.remoteStep = None
         if self.stopCommandOnShutdown:
             self.stopCommand()
-        
+
     # the following are Commands that can be invoked by the master-side
     # Builder
     def remote_startBuild(self):
@@ -257 +257 @@
     def remote_shutdown(self):
         print "slave shutting down on command from master"
         reactor.stop()
-        
-        
+
+
 class Bot(pb.Referenceable, service.MultiService):
     """I represent the slave-side bot."""
     usePTY = None

buildbot/status/web/builder.py

@@ -152 +152 @@
         if not re.match(r'^[\w\.\-\/]*$', revision):
             log.msg("bad revision '%s'" % revision)
             return Redirect("..")
-        if branch == "":
+        if not branch:
             branch = None
-        if revision == "":
+        if not revision:
             revision = None
 
         # TODO: if we can authenticate that a particular User pushed the